felis/community-plugins
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update nightwatch75/dns-switcher to 0.1.2 — fix #292 review notes (#319)

Browse Source 
Addresses the three non-blocking notes from #292:

- README's plugin_api requirement was stale (22) vs the manifest's real
  minimum (17, the onExit lifecycle addition) — corrected, and pinned the
  noctalia version floor to beta.7 (the first tagged release plugin_api
  actually reaches 17 in).
- apply()'s privilege path ran the whole discovery+mutate script through
  `priv sh -c '...'`, which the documented sudoers rule (NOPASSWD:
  /usr/bin/nmcli) never covers — sudo -n always failed. Now the privilege
  prefix is applied to each of the two mutating nmcli calls individually,
  never to a wrapping shell.
- Regenerated thumbnail.webp.

Co-authored-by: nightwatch75 <nightwatch75@users.noreply.github.com>
This commit is contained in:
nightwatch75
2026-08-09 09:53:47 -04:00
committed by GitHub
co-authored by nightwatch75
parent b9d21951ec
commit f222cdee2b
6 changed files with 34 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
dns-switcher/panel.luau
+2 -2
View File
@@ -4,8 +4,8 @@
-- "apply_request" entries this panel emits. Picking a provider applies it
-- immediately (one nmcli change, no reactivation).
local STATE_KEY = "dns_state"
local REQUEST_KEY = "apply_request"
local STATE_KEY = "dns_state" -- published by service.luau
local REQUEST_KEY = "apply_request" -- consumed by service.luau
local RESOLVE_TIMEOUT_MS = 4000